[Fiber] Handle Bailed Out HostText update and MultiChildText test #8371
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sophiebits
approved these changes
Nov 28, 2016
This handles the case where a host text bails out. In that case we need to reuse its previous memoizedProps. We should also only schedule an actual update if it did actually change its text content. I updated the unit test to ignore comment nodes if we're using Fiber.
sebmarkbage
force-pushed
the
fibertext
branch
from
2064a50 to
e66d46a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This handles the case where a host text bails out. In that case we need to reuse its previous memoizedProps. We should also only schedule an actual update if it did actually change its text content.
I updated the unit test to ignore comment nodes if we're using Fiber.
When combined with #8331 the test actually passes.