Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stopgap fix for element disabling #8387

Merged
merged 1 commit into from
Nov 22, 2016
Merged

Conversation

sophiebits
Copy link
Collaborator

Fix for #8308. This is a bad hack -- EventPluginHub.getListener isn't even DOM-specific -- but this works for now and lets us release 15.4.1.

Fix for facebook#8308. This is a bad hack -- EventPluginHub.getListener isn't even DOM-specific -- but this works for now and lets us release 15.4.1.
@sebmarkbage
Copy link
Collaborator

This replaces c6323cb then.

@sophiebits sophiebits merged commit c7129ce into facebook:master Nov 22, 2016
@sophiebits sophiebits added this to the 15-next milestone Nov 22, 2016
@nhunzaker
Copy link
Contributor

Should I migrate this over to #8329 or do you all want to start fresh for a 16.0 fix? I just wanted it fixed really, happy to hand it off to more capable hands.

@sophiebits
Copy link
Collaborator Author

We should probably go with something closer to #8329 long-term although the logic doesn't quite belong in ReactTreeTraversal. Need to figure out where it does belong.

@nhunzaker
Copy link
Contributor

the logic doesn't quite belong in ReactTreeTraversal. Need to figure out where it does belong.

Happy to move discussion over to #8329 but I had two thoughts:

  1. Some sort of injection for traversal that can tag meta data. We just need to keep track of if we're inside of a disabled interactive element or not
  2. Strip out the prop in ReactDOMComponent so that it bubbles over the element, but doesn't result in a binding. We'd still have to pass some way of indicating that an interactive element was inside of a fieldset, but it might be a more natural place to put DOM behavior.

sophiebits added a commit that referenced this pull request Nov 23, 2016
Fix for #8308. This is a bad hack -- EventPluginHub.getListener isn't even DOM-specific -- but this works for now and lets us release 15.4.1.
(cherry picked from commit c7129ce)
@gaearon gaearon modified the milestones: 15.4.1, 15-next Jan 6, 2017
@gaearon
Copy link
Collaborator

gaearon commented Jan 6, 2017

Was the release tool not used for 15.4.1?
This is still tagged as 15-next but it has been released I think.

acusti pushed a commit to brandcast/react that referenced this pull request Mar 15, 2017
Fix for facebook#8308. This is a bad hack -- EventPluginHub.getListener isn't even DOM-specific -- but this works for now and lets us release 15.4.1.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants