-
Notifications
You must be signed in to change notification settings - Fork 46.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stopgap fix for element disabling #8387
Conversation
Fix for facebook#8308. This is a bad hack -- EventPluginHub.getListener isn't even DOM-specific -- but this works for now and lets us release 15.4.1.
This replaces c6323cb then. |
Should I migrate this over to #8329 or do you all want to start fresh for a 16.0 fix? I just wanted it fixed really, happy to hand it off to more capable hands. |
We should probably go with something closer to #8329 long-term although the logic doesn't quite belong in ReactTreeTraversal. Need to figure out where it does belong. |
Happy to move discussion over to #8329 but I had two thoughts:
|
Was the release tool not used for 15.4.1? |
Fix for facebook#8308. This is a bad hack -- EventPluginHub.getListener isn't even DOM-specific -- but this works for now and lets us release 15.4.1.
Fix for #8308. This is a bad hack -- EventPluginHub.getListener isn't even DOM-specific -- but this works for now and lets us release 15.4.1.