Refs between fiber and stack #8458
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
(Non-additive test changes are just to improve test isolation.) |
Collaborator
|
So before we go down this line, do we have an idea of how many more of these issues we could face? Is it only going to be refs? What about warnings/hooks etc? If it's only refs then any hack seems isolated and fine but if it's going to be a few more maybe we need another approach. |
Collaborator
|
(On top of the existing batchedUpdates and findDOMNode hacks) |
Collaborator
Author
|
We could probably have problems if we read the owner and call .getName() on it. Not sure what else. |
sebmarkbage
approved these changes
Nov 30, 2016
Collaborator
sebmarkbage
left a comment
sebmarkbage
left a comment
There was a problem hiding this comment.
Can we mark these some how in a consistent way so that we know to revert them once stack is killed?
I feel gross. Better ideas welcome.
Collaborator
Author
|
Now that I fixed Flow it uses the ReactInstance type in the file so when we remove that we'll notice. |
tomocchino
pushed a commit
to zpao/react
that referenced
this pull request
Dec 1, 2016
I feel gross. Better ideas welcome.
acusti
pushed a commit
to brandcast/react
that referenced
this pull request
Mar 15, 2017
I feel gross. Better ideas welcome.
laurinenas
pushed a commit
to laurinenas/react
that referenced
this pull request
May 28, 2018
I feel gross. Better ideas welcome.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I feel gross. Better ideas welcome.