Skip to content

Conversation

@sophiebits
Copy link
Collaborator

This got messed up in a merge conflict. It's only used for one invariant in renderSubtreeIntoContainer.

@gaearon
Copy link
Collaborator

gaearon commented Nov 30, 2016

This is confusing :-/
Can we rename those to isFiberMountedImpl or something?

This got messed up in a merge conflict. It's only used for one invariant in renderSubtreeIntoContainer.
@sophiebits
Copy link
Collaborator Author

Sure.

@gaearon
Copy link
Collaborator

gaearon commented Nov 30, 2016

Why didn't tests for reflection catch this?

@gaearon
Copy link
Collaborator

gaearon commented Nov 30, 2016

Oh I guess because

It's only used for one invariant in renderSubtreeIntoContainer.

nevermind

@sophiebits sophiebits added this to the 15-next milestone Nov 30, 2016
@sophiebits sophiebits merged commit 545a193 into facebook:master Nov 30, 2016
tomocchino pushed a commit to zpao/react that referenced this pull request Dec 1, 2016
This got messed up in a merge conflict. It's only used for one invariant in renderSubtreeIntoContainer.
acusti pushed a commit to brandcast/react that referenced this pull request Mar 15, 2017
This got messed up in a merge conflict. It's only used for one invariant in renderSubtreeIntoContainer.
laurinenas pushed a commit to laurinenas/react that referenced this pull request May 28, 2018
This got messed up in a merge conflict. It's only used for one invariant in renderSubtreeIntoContainer.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants