Added circle.yml and scripts/circleci back in #8745
Conversation
|
I don’t think those were linting errors, they were warnings. Changes not specific to |
| "gulp-util": "^3.0.7", | ||
| "gzip-js": "~0.3.2", | ||
| "jest": "^15.1.1", | ||
| "jest-cli": "^15.1.1", |
There was a problem hiding this comment.
I think that just adding jest-cli is not enough.
The problem is we haven't synced package.json for a while, and we need to update it to match what we have on master. For example we already have jest-cli@18 there.
In general, in this PR the goal is to bring it as close as possible to master. We probably missed some commits at some point. There shouldn't be much intentional divergence between 15-stable and master. So now that you found a set of changes that work, could you also reduce it so that it matches master whenever possible?
There was a problem hiding this comment.
In terms of linting, would it be preferable to pull in the eslint updates from master and make 15-stable conform? Or update 15-stable to conform to its current linting rules? I seem to be getting linting errors on install due to these changes and this rule. That rule was removed in 16.
There was a problem hiding this comment.
It’s best to make it as close to master as we can in terms of linting setup. It would make sense to me to have 32f5b03 and similar changes cherry-picked.
|
Superseded by #8778. |
3 participants
Fixes #8744