Deprecate React.createMixin #8853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
January 23, 2017 18:14
This API was never fully implemented. Since mixins are no longer considered part of the future React API, it will be removed.
aweary
commented
Jan 24, 2017
| warning( | ||
| warnedForCreateMixin, | ||
| 'React.createMixin is deprecated and should not be used. You ' + | ||
| 'can use your mixin directly instead.' |
There was a problem hiding this comment.
I considered adding some messaging here about mixins being considered harmful, but I'm not sure if that's overstepping since they're not actually considered deprecated.
gaearon
reviewed
Jan 24, 2017
| warning( | ||
| warnedForCreateMixin, | ||
| 'React.createMixin is deprecated and should not be used. You ' + | ||
| 'can use your mixin directly instead.' |
There was a problem hiding this comment.
"You can use your mixin" sounds a bit aggressive, maybe "You can use this mixin"?
gaearon
approved these changes
Jan 24, 2017
|
CI is failing, looks related to this: |
|
I don't think so. It seems like this was broken by #8858: we didn't run the tests in Fiber mode and one of the tests seems to assert a different warning message. |
Closed
1 task
This was referenced Aug 26, 2019
This was referenced Sep 22, 2019
This was referenced Jan 23, 2020
This was referenced Feb 23, 2020
This was referenced Mar 18, 2020
This was referenced Mar 27, 2020
This was referenced May 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One step towards #8852. This also adds tests for the deprecation warning, along with the
React.__spreadmethod. I didn't see a good place to stick these tests, so I just created a new__tests__folder insrc/isomorphic.