Skip to content

Conversation

@roman01la
Copy link
Contributor

fixes #8887

Copy link
Contributor

@aweary aweary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@aweary aweary merged commit 59aac01 into facebook:master Jan 31, 2017
@aweary aweary added this to the 15-lopri milestone Jan 31, 2017
@petterik
Copy link

It doesn't seem like this PR went in to the 15.6.2 branch?
https://github.com/facebook/react/blame/15.6.2-dev/src/renderers/dom/shared/DOMPropertyOperations.js#L147

I don't see this change in the release of React 15.6.1. Would it be possible to get it to 15.6.2?
@aweary ?

@danielbraun
Copy link

@petterik It went into React 16.0.0
https://github.com/facebook/react/blob/v16.0.0/src/renderers/dom/shared/DOMPropertyOperations.js#L170

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Usage of this in DOMPropertyOperations module breaks build in Closure Compiler under advanced optimizations

5 participants