-
Notifications
You must be signed in to change notification settings - Fork 46.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closure Compiler wrong assignment order in instantiateReactComponent
#8895
Conversation
Can we get this reviewed? This simple change alone can go a long way empowering Google Closure Compiler users to get dead-code elimination on React by consuming it from a |
instantiateReactComponent
This looks fine by itself. However, just to set expectations, I’m not quite sure when we’ll cut another patch release, and React 16 will contain a completely rewritten core, so this change won’t affect it. |
Thanks! I understand. So to avoid encountering similar problems with Fiber, are there instructions to build master locally and take it for a spin? |
Yea. You should be able to build from master and then import |
Great. Will do and report any issues I encounter along the way. |
@gaearon Don't know where else to provide feedback, but everything seems to work successfully when consuming ReactDOMFiber with the Google Closure Compiler 👍 |
This fixes #8894