Remove experimental support for maps as children #8936
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaearon
approved these changes
Feb 6, 2017
Collaborator
gaearon
left a comment
gaearon
left a comment
There was a problem hiding this comment.
Looks good to me (if it passes)
sebmarkbage
reviewed
Feb 6, 2017
| if (iteratorFn) { | ||
| var iterator = iteratorFn.call(children); | ||
| var step; | ||
| if (iteratorFn !== children.entries) { |
Collaborator
There was a problem hiding this comment.
Maybe we should still warn in the case iteratorFn !== children.entries in case we want to have this back? People shouldn't use maps where the key is implicitly another child. Could create strange bugs.
The entries of a map are a two-element array of [key, value], which React will treat as fragments with children. This is unlikely to ever be the intended behavior, so we warn.
acdlite
force-pushed
the
removemapsaschildren
branch
from
1b8d7db to
14962f8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were already warning so this can go in the next major release.