Skip to content

add bullet point for testing in tutorial (#9248) #9251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

bernard-lin
Copy link
Contributor

@bernard-lin bernard-lin commented Mar 24, 2017

#9248
Before submitting a pull request, please make sure the following is done:

  1. Fork the repository and create your branch from master.
  2. If you've added code that should be tested, add tests!
  3. If you've changed APIs, update the documentation.
  4. Ensure the test suite passes (npm test).
  5. Make sure your code lints (npm run lint).
  6. Format your code with prettier (npm run prettier).
  7. Run the Flow typechecks (npm run flow).
  8. If you added or removed any tests, run ./scripts/fiber/record-tests before submitting the pull request, and commit the resulting changes.
  9. If you haven't already, complete the CLA.

@gaearon
Copy link
Collaborator

gaearon commented Apr 18, 2017

Hey, I’m very sorry for closing this since you acted on a contributor suggestion. Please see my reply in #9248 (comment) for the reason I’m closing the PR. I appreciate the effort!

@gaearon gaearon closed this Apr 18, 2017
@bernard-lin
Copy link
Contributor Author

No worries! I appreciate the discussion you and Brandon are having in the other thread

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants