Support un-braced element prop in JSX transform #933
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebookarchive/esprima#9 makes this possible.
|
esprima-fb version has been pumped in #1095 |
sophiebits
changed the title
|
I'm going to say no to this. For others who find this, the idea was to allow shorthand for passing in components. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like
<LeftRight left=<a /> right=<b /> />. facebookarchive/esprima#9 makes this possible.This should be merged with an esprima-fb version bump. However, facebookarchive/esprima@8ca1599 necessitates a change to this transform to look at
object.openingElementin most cases so I'll wait for an updated version to be synced out before this can be merged.