Update typechecking-with-proptypes.md #9392
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aweary
reviewed
Apr 10, 2017
| optionalObject: React.PropTypes.object, | ||
| optionalString: React.PropTypes.string, | ||
| optionalSymbol: React.PropTypes.symbol, | ||
| optionalArray: array, |
Contributor
There was a problem hiding this comment.
This should be PropTypes.array
| With `PropTypes.element` you can specify that only a single child can be passed to a component as children. | ||
|
|
||
| ```javascript | ||
| import PropTypes from 'prop-types'; |
Contributor
There was a problem hiding this comment.
Should we just import element since it's the only PropType in the example?
aweary
approved these changes
Apr 10, 2017
Collaborator
|
So which import style do we recommend? |
Collaborator
|
I changed to use |
gaearon
pushed a commit
that referenced
this pull request
Apr 11, 2017
* Update typechecking-with-proptypes.md * Update typechecking-with-proptypes.md * Use consistent style for PropTypes import
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the documentation for type-checking with PropTypes, removing the usage of
React.PropTypesin favor of the NPM package.