Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Very small changes #9457

Closed
wants to merge 1 commit into from
Closed

Very small changes #9457

wants to merge 1 commit into from

Conversation

radi-cho
Copy link

Added:

  • link about createElement;
  • note about React.Component.

Added:
- link about createElement;
- note about React.Component.
@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

If you are contributing on behalf of someone else (eg your employer): the individual CLA is not sufficient - use https://developers.facebook.com/opensource/cla?type=company instead. Contact cla@fb.com if you have any questions.

Copy link
Collaborator

@gaearon gaearon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see review comments—I don’t think we can take this unless the change is more consistent.

@@ -85,6 +85,8 @@ class ShoppingList extends React.Component {
// Example usage: <ShoppingList name="Mark" />
```

> You can import ```{ Component } from react``` and you can use only ```Component``` instead ```React.Component```;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is important in this tutorial (and it's not relevant for most people who would follow along on CodePen).

@@ -98,6 +100,8 @@ return React.createElement('div', {className: 'shopping-list'},
);
```

https://facebook.github.io/react/docs/react-api.html#createelement
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just placing a link like this is not very helpful. Is there a better way we could do it? I would also prefer that we do this consistently for all API rather than in one place.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I will close this pull request, but I will open another, better request. Thanks for activity, @gaearon I'm big your fan (I'm 11 years old and now I learning to develop with react)...

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@radi-cho radi-cho closed this Apr 19, 2017
@radi-cho
Copy link
Author

@gaearon view this: #9459

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants