Prepare react-dom-factories for publishing
#9823
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**what is the change?:** - copies the `React.DOM.*` factory helpers into the package and wraps them with an IIFE - set peerDependency on React to latest 15 version **why make this change?:** We are deprecating `React.DOM.*` and this provides a fallback option for those using it. We just copied the code in order to avoid a circular dependency, which keeps complexity down since we are supporting every possible build system. **test plan:** TODO - 1. Copy this into one of our fixtures using a UMD/AMD build and see if it works there. 2. Do an initial publish of the package on npm and then pull it into CRA, and try it there. 3. Try it in https://github.com/duncanbeevers/jade-react or some other project that actually uses the `React.DOM.*` helpers, using the related codemod. **issue:** facebook#9398
sophiebits
approved these changes
May 31, 2017
| } | ||
|
|
||
| if (typeof g.React === "undefined") { | ||
| throw Error("React module should be required before reactDOMFactories"); |
nhunzaker
approved these changes
May 31, 2017
Contributor
nhunzaker
left a comment
nhunzaker
left a comment
There was a problem hiding this comment.
Nothing else beyond what Ben said. Looks good to me!
**what is the change?:** Fixing nits in capitalization, quotes, and defined globals **why make this change?:** To get CI passing, consistency, correctness **test plan:** see prev. commit **issue:** facebook#9398
Contributor
Author
|
Testing of the UMD build in our 'systemjs', 'requirejs', and 'globals' fixtures was successful. |
Contributor
Author
|
Further testing of the npm module with all other builds showed no problems. |
flarnie
added a commit
to flarnie/react
that referenced
this pull request
Jun 7, 2017
* Prepare `react-dom-factories` for publishing **what is the change?:** - copies the `React.DOM.*` factory helpers into the package and wraps them with an IIFE - set peerDependency on React to latest 15 version **why make this change?:** We are deprecating `React.DOM.*` and this provides a fallback option for those using it. We just copied the code in order to avoid a circular dependency, which keeps complexity down since we are supporting every possible build system. **test plan:** TODO - 1. Copy this into one of our fixtures using a UMD/AMD build and see if it works there. 2. Do an initial publish of the package on npm and then pull it into CRA, and try it there. 3. Try it in https://github.com/duncanbeevers/jade-react or some other project that actually uses the `React.DOM.*` helpers, using the related codemod. **issue:** facebook#9398 * Fix lints and capitalization of 'reactDOMFactories' **what is the change?:** Fixing nits in capitalization, quotes, and defined globals **why make this change?:** To get CI passing, consistency, correctness **test plan:** see prev. commit **issue:** facebook#9398
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what is the change?:
React.DOM.*factory helpers into the package and wrapsthem with an IIFE
why make this change?:
We are deprecating
React.DOM.*and this provides a fallback option forthose using it.
We just copied the code in order to avoid a circular dependency, which
keeps complexity down since we are supporting every possible build
system.
test plan:
DONE -
it works there.
TODO -
2. Do an initial publish of the package on npm and then pull it into
CRA, and try it there.
3. Try it in https://github.com/duncanbeevers/jade-react or some other
project that actually uses the
React.DOM.*helpers, using therelated codemod.
issue:
#9398