Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'create-react-class' to react dependencies for build #9847

Conversation

flarnie
Copy link
Contributor

@flarnie flarnie commented Jun 4, 2017

what is the change?:
We needed this dependency in the package.json

why make this change?:
Even though create-react-class was added as a dependency to the
package.json in https://github.com/facebook/react/pull/9399/files we
didn't completely cherry-pick this change onto 15.6 from master in b48b259

This fixes that omission.
Following this fix we will review PR 9399 and make sure nothing else was
missed.

test plan:
yarn build and inspect the builds/packages/react/package.json, see
that create-react-class is included.

issue:
#9830

Before submitting a pull request, please make sure the following is done:

  1. Fork the repository and create your branch from master.
  2. If you've added code that should be tested, add tests!
  3. If you've changed APIs, update the documentation.
  4. Ensure the test suite passes (npm test).
  5. Make sure your code lints (npm run lint).
  6. Format your code with prettier (npm run prettier).
  7. Run the Flow typechecks (npm run flow).
  8. If you added or removed any tests, run ./scripts/fiber/record-tests before submitting the pull request, and commit the resulting changes.
  9. If you haven't already, complete the CLA.

**what is the change?:**
We needed this dependency in the package.json

**why make this change?:**
Even though `create-react-class` was added as a dependency to the
`package.json` in https://github.com/facebook/react/pull/9399/files we
didn't completely cherry-pick this change onto 15.6 from master in facebook@b48b259

This fixes that omission.
Following this fix we will review PR 9399 and make sure nothing else was
missed.

**test plan:**
`yarn build` and inspect the `builds/packages/react/package.json`, see
that `create-react-class` is included.

**issue:**
facebook#9830
@flarnie flarnie added this to the 15.6 milestone Jun 4, 2017
@flarnie flarnie requested review from sophiebits, gaearon and trueadm June 4, 2017 17:42
@flarnie flarnie merged commit e5b3554 into facebook:15.6-dev Jun 5, 2017
flarnie added a commit to flarnie/react that referenced this pull request Jun 7, 2017
**what is the change?:**
We needed this dependency in the package.json

**why make this change?:**
Even though `create-react-class` was added as a dependency to the
`package.json` in https://github.com/facebook/react/pull/9399/files we
didn't completely cherry-pick this change onto 15.6 from master in facebook@b48b259

This fixes that omission.
Following this fix we will review PR 9399 and make sure nothing else was
missed.

**test plan:**
`yarn build` and inspect the `builds/packages/react/package.json`, see
that `create-react-class` is included.

**issue:**
facebook#9830
@flarnie flarnie deleted the addMissingCreateReactClassDependencyTo15.6 branch May 25, 2018 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants