Add 'create-react-class' to react dependencies for build #9847
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what is the change?:
We needed this dependency in the package.json
why make this change?:
Even though
create-react-class
was added as a dependency to thepackage.json
in https://github.com/facebook/react/pull/9399/files wedidn't completely cherry-pick this change onto 15.6 from master in b48b259
This fixes that omission.
Following this fix we will review PR 9399 and make sure nothing else was
missed.
test plan:
yarn build
and inspect thebuilds/packages/react/package.json
, seethat
create-react-class
is included.issue:
#9830
Before submitting a pull request, please make sure the following is done:
master
.npm test
).npm run lint
).npm run prettier
).npm run flow
)../scripts/fiber/record-tests
before submitting the pull request, and commit the resulting changes.