Remove useCreateElement flag #9873
Merged
+141
−233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaearon
commented
Jun 6, 2017
scripts/circleci/test_entry_point.sh
Outdated
| @@ -12,10 +12,6 @@ if [ $((2 % CIRCLE_NODE_TOTAL)) -eq "$CIRCLE_NODE_INDEX" ]; then | |||
| COMMANDS_TO_RUN+=('./scripts/circleci/test_fiber.sh') | |||
| fi | |||
|
|
|||
| if [ $((3 % CIRCLE_NODE_TOTAL)) -eq "$CIRCLE_NODE_INDEX" ]; then | |||
There was a problem hiding this comment.
Can we reuse this node now for something else? Should we?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the flag that used to force Stack into HTML generation mode even for client side.
It should make our CI runs a bit faster.
Note that we didn’t rely on this in the bundles for a long time.
The only real use of this flag was the HTML generation test that we run on CI.
However it no longer represents the way forward (server renderer was separated from Stack), and we have a new suite that covers HTML generation specifically that's independent of this flag.
I still keep the actual HTML generation codepath in the DOMStack, so that we can keep using the Stack bundle. It's just not covered by the normal Stack tests anymore (but it's still covered by new integration tests).