-
Notifications
You must be signed in to change notification settings - Fork 46.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport Safari fix for input changes #9960
Conversation
Can you verify this works on Safari? |
I can't right this moment, I yanked this straight from master (#6648) so presumably FB would be broken still if it didn't? :P |
That's my thinking too. 😄 Let's get in. Thanks. |
(I'll still wait for CI) |
Eh, seems like I broke CI with lint 😞 This is okay to merge:
|
Some brower do not support |
@blling Yikes! Do you know in which browsers this is the case? |
I found IE8 for now... I know React has dropped support of IE8~~, but if you could use |
@nhunzaker do you think the issue of |
I don't think so, we are actively removing ie8 specific code. I don't think it makes sense to cover that case just here |
Yeah; that's where I'm at too. |
o_o |
fixes #9956