Skip to content

Commit

Permalink
Removing warning
Browse files Browse the repository at this point in the history
Summary: Joe recently added warning in the transform to show up when people write
queries with first.before and last.after so we dont need this warning anymore.
We still have to keep the if block since adding logic to read those queries is not trivial and it's only used
to try to reuse edges when we write data from diff queries. We don't about to worry about these types of queries
on the read path since we don't allow these queries in the components.

Reviewed By: @yungsters

Differential Revision: D2425425
  • Loading branch information
yuzhi authored and facebook-github-bot-2 committed Sep 10, 2015
1 parent d0cb2ce commit a04a514
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions src/legacy/store/GraphQLRange.js
Original file line number Diff line number Diff line change
Expand Up @@ -761,10 +761,6 @@ class GraphQLRange {
}
if ((calls.first && calls.before) || (calls.last && calls.after)) {
// TODO #7556678: add support for first/before and last/after
console.warn(
'GraphQLRange does not currently handle retrieval for ' +
'before(<cursor>).first(<count>) and after(<cursor>).last(<count>)'
);
return {
requestedEdgeIDs: [],
diffCalls: [],
Expand Down

0 comments on commit a04a514

Please sign in to comment.