-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Rust][Compiler] Add Configuration/Document Query Persisting in the OSS Compiler #3627
Comments
This in order to support |
In the rust version, we decided to expose the persisting mechanism we are using internally. Basically, we're sending (HTTP post) full query text to the API endpoint, that knows how/where to save the query text, and it can return a persisted query ID for it. This task is just to add documentation for it and expose it via SingleProjectConfigFile, here: https://github.com/facebook/relay/blob/main/compiler/crates/relay-compiler/src/config.rs#L630 And yeah, with persisted query IDs @preloadable can generate $parameters files that can be used with entry-points. But maybe there is something else we need to add. |
Summary: For more details see: #3627 Reviewed By: kassens Differential Revision: D32261009 fbshipit-source-id: c4cc581b2be8b5372b346e7a796df24578e5463a
It’s great to know the Rust version of the Relay compiler has Will there still be a way to locally persist the queries (e.g. writing into a JSON file locally like the JS version)? Thanks! Update: @vincentriemer is working on it #3666 🚀 |
Thanks @wongmjane! Currently, we don't have this, but it should not be difficult change to add support for this. We always welcome contributions and are happy to review and merge them :-) |
The text was updated successfully, but these errors were encountered: