Unexpected behavior with @include / @skip directives

[vladar]

I have following fragment:

fragment on Story {
  id
  comments @include(if: $showComments) {
    id
    text
  }
}

Then somewhere in the app I have a list of Stories. When $showComments is true everything works as expected. But when $showComments is false Relay sends additional GraphQL query for each story after initial load.

This query is sent to Node interface and includes this Story fragment (+child fragments if any) as well as id and __typename fields.

The response returned is always the same:

{
  "node": {
    "__typename": "Story",
    "id": "node-id-value"
  }
}

Same applies to @skip(if: true) directive.

[josephsavona]

Relay currently passes through directives to the server but does not directly implement support for @include or @skip. We should add support such that:

• unincluded fields (include: false or skip: true) are removed during diffing
• reader does not return unincluded fields

Contributions welcome, otherwise we'll get to this as time permits.

[josephsavona]

merged into #536