Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Full support for @include and @skip directives #536

Closed
josephsavona opened this issue Nov 2, 2015 · 2 comments
Closed

Full support for @include and @skip directives #536

josephsavona opened this issue Nov 2, 2015 · 2 comments
Labels
enhancement help wanted

Comments

@josephsavona
Copy link
Contributor

Relay currently passes through directives to the server, but does not directly implement support for @include or @skip. The outward effects of this are that skipped fields (either include: false or skip: true) are not sent to the server, and that data for skipped fields is not returned to components in props.

The simplest implementation of the above is to make RelayQueryNode.getChildren() not return child fields that are skipped.

Contributions welcome, otherwise we'll get to this as time permits.
This was referenced Nov 2, 2015
Closed
Closed
@xuorig xuorig mentioned this issue Nov 3, 2015
Closed
@ghost ghost closed this as completed in b7bb2c0 Nov 10, 2015
@josephsavona
Copy link
Contributor Author

@xuorig thanks for the PR!

@xuorig
Copy link
Contributor

xuorig commented Nov 10, 2015

🎉

@shahankit shahankit mentioned this issue Jan 13, 2016
Closed
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@xuorig @josephsavona