-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RelayDefaultNetworkLayer, throw Error also on non-200 response. #1163
Closed
Closed
Changes from 6 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
7ced8d2
RelayDefaultNetworkLayer, throw Error also on non-200 response.
Globegitter e3801e0
change response.
Globegitter 73e3a5e
Fix test.
Globegitter 64dad6c
Merge branch 'master' into mutation-error-return
Globegitter d3830d2
Slightly improved test.
Globegitter 8cabc5d
Fix status code check.
Globegitter b5949fc
Merge branch 'master' into mutation-error-return
Globegitter 2a2c6ba
Pulled out error creation into common code.
Globegitter cee2021
Remove comment.
Globegitter File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -36,6 +36,14 @@ describe('RelayDefaultNetworkLayer', () => { | |
}; | ||
} | ||
|
||
function genFailureResponse(data) { | ||
return { | ||
json: () => Promise.resolve(data), | ||
text: () => Promise.resolve(JSON.stringify(data)), | ||
status: 500, | ||
}; | ||
} | ||
|
||
beforeEach(() => { | ||
jest.resetModuleRegistry(); | ||
|
||
|
@@ -229,6 +237,31 @@ describe('RelayDefaultNetworkLayer', () => { | |
expect(error.source).toEqual(response); | ||
}); | ||
|
||
it('handles server-side non-2xx errors', () => { | ||
const response = { | ||
errors: [{ | ||
message: 'Something went completely wrong.' | ||
}], | ||
}; | ||
|
||
expect(fetch).not.toBeCalled(); | ||
networkLayer.sendMutation(request); | ||
expect(fetch).toBeCalled(); | ||
const failureResponse = genFailureResponse(response); | ||
expect(failureResponse.status >= 300 || failureResponse.status < 200).toBeTruthy(); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Since |
||
|
||
fetch.mock.deferreds[0].resolve(failureResponse); | ||
jest.runAllTimers(); | ||
|
||
expect(rejectCallback.mock.calls.length).toBe(1); | ||
const error = rejectCallback.mock.calls[0][0]; | ||
expect(error instanceof Error).toBe(true); | ||
expect(error.message).toEqual('{"errors":[{"message":"Something went ' + | ||
'completely wrong."}]}'); | ||
expect(error.status).toEqual(failureResponse.status); | ||
expect(error.source).toBe(undefined); | ||
}); | ||
|
||
}); | ||
|
||
describe('sendQueries', () => { | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How would you feel about sharing the code that already handles mutation errors (see
if (payload.hasOwnProperty('errors')
ofsendMutation()
)? Perhaps we should trigger the same error handling code whenerrors
is present in the payload or when the status is non-200.