Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solving issues for relay 0.9 and it examples #1178

Closed
wants to merge 1 commit into from

Conversation

CoericK
Copy link
Contributor

@CoericK CoericK commented May 27, 2016

Adding this will allow run the examples on /examples directory.

@ghost
Copy link

ghost commented May 27, 2016

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

@ghost
Copy link

ghost commented May 27, 2016

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@ghost ghost added the CLA Signed label May 27, 2016
@CoericK
Copy link
Contributor Author

CoericK commented May 27, 2016

@facebook-github-bot import

@josephsavona
Copy link
Contributor

josephsavona commented May 27, 2016

@CoericK thanks for the PR. We'll take a look and import this as soon as we can (external contributors aren't able to import PRs).

@CoericK
Copy link
Contributor Author

CoericK commented May 27, 2016

Np @josephsavona, hope I can get involve more on the comunity.

@steveluscher
Copy link
Contributor

I'm pretty confident that the root issue is #1177 – namely that npm preinstall no longer works as we expect it does. We used to preinstall all of Relay and the Babel plugin before even starting to pull in the example apps' dependencies. Npm >=v3 changed how preinstall behaves. Our fix for this is to forego this entire step, and install the release versions of Relay and the Babel plugin for use in the example apps (#1183). This should work for most people, most of the time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants