Expose injectCacheManager on RelayEnvironment #1320
Conversation
ghost
added
the
| it('passes down the cacheManager to the store data', () => { | ||
| const mockCacheManager = {}; | ||
| environment.injectCacheManager(mockCacheManager); | ||
| expect(environment._storeData._cacheManager).toEqual(mockCacheManager); |
There was a problem hiding this comment.
expect(environment.getStoreData().getCacheManager()).toBe(mockCacheManager);
There was a problem hiding this comment.
Thanks, forgot about getStoreData() and getCacheManager(). Fixed 👍
aweary
force-pushed
the
expose-inject-cache-manager
branch
from
06c1eb5 to
4ce48ea
Compare
|
@facebook-github-bot shipit |
|
Thanks for importing.If you are an FB employee go to Phabricator to review internal test results. |
|
@josephsavona do you know why the test is failing? is |
|
Not sure, I would try logging some of the values and see. |
| const mockCacheManager = {}; | ||
| environment.injectCacheManager(mockCacheManager); | ||
| expect( | ||
| environment.getStoreData().getCacheManager() |
There was a problem hiding this comment.
getCacheManager don't seem to exist (there is no such method in the RelayStoreData class)
There was a problem hiding this comment.
Weird, thought we had that. Anyway, let's add and use it here.
There was a problem hiding this comment.
I can add it in this PR if you'd like
|
@facebook-github-bot shipit |
|
Thanks for importing.If you are an FB employee go to Phabricator to review internal test results. |
|
@aweary thanks for this! |
RelayEnvironmentexposes most of the other injection methods forRelayStoreData, so this just addsinjectCacheManageras well. Even though it's not a documented API, adding it toRelayEnvironmentwill make it easier for those who do want to use it while its "experimental" which paves the way for a stable implementation.I also added a basic test that just verifies the injection works as expected.