-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
babel-relay-plugin: generalize warning about nodes
fields
#185
Merged
josephsavona
merged 1 commit into
facebook:master
from
josephsavona:babel-plugin-generalize-nodes-warning
Aug 28, 2015
Merged
babel-relay-plugin: generalize warning about nodes
fields
#185
josephsavona
merged 1 commit into
facebook:master
from
josephsavona:babel-plugin-generalize-nodes-warning
Aug 28, 2015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josephsavona
force-pushed
the
babel-plugin-generalize-nodes-warning
branch
from
August 28, 2015 02:15
f51bf9f
to
3ea72ac
Compare
josephsavona
force-pushed
the
babel-plugin-generalize-nodes-warning
branch
2 times, most recently
from
August 28, 2015 02:22
a382495
to
949edb3
Compare
josephsavona
force-pushed
the
babel-plugin-generalize-nodes-warning
branch
from
August 28, 2015 02:25
949edb3
to
e41cac7
Compare
'Unsupported "nodes" field on connection, `%s`. Instead, use ' + | ||
'"edges{node{...}}".', | ||
'Unsupported `%s{...}` field on connection `%s`. Use ' + | ||
'`edges{node{...}}` instead.', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be worth expanding on this warning to explain why this is unsupported?
'`%s{...}` field on connection `%s` does not allow cursor insertion. ' +
'Use `edges{node{...}}` instead to allow Relay to auto-insert ' +
'`edges{cursor}` for efficient pagination',
josephsavona
added a commit
that referenced
this pull request
Aug 28, 2015
…es-warning babel-relay-plugin: generalize warning about `nodes` fields
This was referenced Jul 9, 2020
This was referenced Aug 16, 2020
This was referenced Aug 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GraphQL servers may support various forms of pagination, for example:
Relay currently supports only a) - the
edges{node{...}}
variant, and warns about case b) only if the field is callednodes
. This PR changes the warning by detecting any use of the b) pattern regardless of the field's name.cc @dschafer @leebyron @schrockn @yuzhi