Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring the examples into the era of 0.14.0-rc and ReactDOM #290

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion examples/relay-treasurehunt/js/app.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import 'babel/polyfill';
import App from './components/App';
import AppHomeRoute from './routes/AppHomeRoute';

React.render(
ReactDOM.render(
<Relay.RootContainer
Component={App}
route={new AppHomeRoute()}
Expand Down
3 changes: 2 additions & 1 deletion examples/relay-treasurehunt/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,8 @@
"express-graphql": "^0.3.0",
"graphql": "^0.4.2",
"graphql-relay": "^0.3.1",
"react": "^0.14.0-beta3",
"react": "^0.14.0-rc",
"react-dom": "^0.14.0-rc",
"react-relay": "file:../../",
"webpack": "^1.10.5",
"webpack-dev-server": "^1.10.1"
Expand Down
1 change: 1 addition & 0 deletions examples/relay-treasurehunt/public/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
</script>
<script src="http://localhost:3000/webpack-dev-server.js"></script>
<script src="node_modules/react/dist/react.min.js"></script>
<script src="node_modules/react/dist/react-dom.min.js"></script>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Total tangent, but it might make sense to use the dev builds of these

<script src="node_modules/react-relay/dist/relay.js" onerror="warnRelayMissing()"></script>
<script src="js/app.js"></script>
</body>
Expand Down
1 change: 1 addition & 0 deletions examples/star-wars/.eslintrc
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ env:
globals:
document: false
React: false
ReactDOM: false
Relay: false

arrowFunctions: true
Expand Down
2 changes: 1 addition & 1 deletion examples/star-wars/js/app.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import 'babel/polyfill';
import StarWarsApp from './components/StarWarsApp';
import StarWarsAppHomeRoute from './routes/StarWarsAppHomeRoute';

React.render(
ReactDOM.render(
<Relay.RootContainer
Component={StarWarsApp}
route={new StarWarsAppHomeRoute({
Expand Down
3 changes: 2 additions & 1 deletion examples/star-wars/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,8 @@
"express-graphql": "^0.3.0",
"graphql": "^0.4.2",
"graphql-relay": "^0.3.1",
"react": "^0.14.0-beta3",
"react": "^0.14.0-rc",
"react-dom": "^0.14.0-rc",
"react-relay": "file:../../",
"webpack": "^1.10.5",
"webpack-dev-server": "^1.10.1"
Expand Down
1 change: 1 addition & 0 deletions examples/star-wars/public/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
</script>
<script src="http://localhost:3000/webpack-dev-server.js"></script>
<script src="node_modules/react/dist/react.min.js"></script>
<script src="node_modules/react/dist/react-dom.min.js"></script>
<script src="node_modules/react-relay/dist/relay.js" onerror="warnRelayMissing()"></script>
<script src="js/app.js"></script>
</body>
Expand Down
1 change: 1 addition & 0 deletions examples/todo/.eslintrc
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ env:
globals:
document: false
React: false
ReactDOM: false
Relay: false

arrowFunctions: true
Expand Down
2 changes: 1 addition & 1 deletion examples/todo/js/app.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import 'babel/polyfill';
import TodoApp from './components/TodoApp';
import TodoAppHomeRoute from './routes/TodoAppHomeRoute';

React.render(
ReactDOM.render(
<Relay.RootContainer Component={TodoApp} route={new TodoAppHomeRoute()} />,
document.getElementById('root')
);
2 changes: 1 addition & 1 deletion examples/todo/js/components/TodoTextInput.js
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ export default class TodoTextInput extends React.Component {
text: this.props.initialValue || '',
};
componentDidMount() {
React.findDOMNode(this).focus();
ReactDOM.findDOMNode(this).focus();
}
_commitChanges = () => {
var newText = this.state.text.trim();
Expand Down
3 changes: 2 additions & 1 deletion examples/todo/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,8 @@
"express-graphql": "^0.3.0",
"graphql": "^0.4.2",
"graphql-relay": "^0.3.1",
"react": "^0.14.0-beta3",
"react": "^0.14.0-rc",
"react-dom": "^0.14.0-rc",
"react-relay": "file:../../",
"todomvc-app-css": "^2.0.1",
"todomvc-common": "^1.0.2",
Expand Down
1 change: 1 addition & 0 deletions examples/todo/public/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
<script src="http://localhost:3000/webpack-dev-server.js"></script>
<script src="node_modules/todomvc-common/base.js"></script>
<script src="node_modules/react/dist/react.min.js"></script>
<script src="node_modules/react/dist/react-dom.min.js"></script>
<script src="node_modules/react-relay/dist/relay.js" onerror="warnRelayMissing()"></script>
<script src="js/app.js"></script>
</body>
Expand Down
6 changes: 4 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,8 @@
"react-static-container": "^1.0.0-alpha.1"
},
"peerDependencies": {
"react": "^0.14.0-beta3"
"react": "^0.14.0-rc",
"react-dom": "^0.14.0-rc"
},
"devDependencies": {
"babel-core": "^5.8.23",
Expand All @@ -57,7 +58,8 @@
"gulp-util": "^3.0.6",
"jest-cli": "^0.5.0",
"object-assign": "^3.0.0",
"react": "^0.14.0-beta3",
"react": "^0.14.0-rc",
"react-dom": "^0.14.0-rc",
"run-sequence": "^1.1.2",
"webpack": "1.11.0",
"webpack-stream": "^2.1.0"
Expand Down
2 changes: 1 addition & 1 deletion website-prototyping-tools/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
"normalize.css": "3.0.3",
"query-string": "2.4.0",
"raw-loader": "0.5.1",
"react": "^0.14.0-beta3",
"react": "^0.14.0-rc",
"react-codemirror": "0.1.5",
"react-relay": "../",
"style-loader": "0.12.3",
Expand Down