Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the website-building docs #300

Closed
wants to merge 1 commit into from
Closed

Conversation

steveluscher
Copy link
Contributor

No description provided.

@wincent
Copy link
Contributor

wincent commented Sep 12, 2015

Did you mean to create a website-building-docs branch directly on the https://github.com/facebook/relay repo? (I thought you might have done it by accident.)

@steveluscher
Copy link
Contributor Author

I did.

I don't have my own fork of Relay, and I prefer to keep feature branches as close to facebook/relay#master as possible. That, and I always clean up merged branches.

I realize that this is an unpopular way of working, and an exclusive privilege of those with push access to this repository. Though I find this workflow to be simple and effective, I'm open to being compelled to change.

@wincent
Copy link
Contributor

wincent commented Sep 14, 2015

Though I find this workflow to be simple and effective, I'm open to being compelled to change.

I think it's fine, so I wouldn't try to compel you. FWIW, the two reasons I push to my fork rather than here directly are that:

  1. There are a lot of eyes on this repo, so I prefer to avoid any confusion about such a branch enjoying "official" status when it's actually just a work-in-progress that's going to get deleted.
  2. I like the layer of indirection that prevents me from doing something silly or destructive like pushing the wrong branch, or overwriting a branch etc in a highly visible place.

But I think you should keep doing whatever works for you.

@steveluscher steveluscher deleted the website-building-docs branch September 15, 2015 07:16
steveluscher added a commit that referenced this pull request Sep 18, 2015
Summary: Closes #300

Reviewed By: @​#relay, @wincent

Differential Revision: D2436312
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants