Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[js-compiler] add test for explicit null argument #3047

Closed
wants to merge 2 commits into from

Conversation

kassens
Copy link
Member

@kassens kassens commented Mar 13, 2020

Adds a test for the (incorrect) behavior that null arguments to fields are stripped by the compiler.

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kassens has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@kassens merged this pull request in 027fbd1.

@kassens kassens deleted the null-arg branch March 16, 2020 03:01
jstejada pushed a commit that referenced this pull request Apr 29, 2020
Summary:
Adds a test for the (incorrect) behavior that null arguments to fields are stripped by the compiler.
Pull Request resolved: #3047

Reviewed By: alunyov

Differential Revision: D20449316

Pulled By: kassens

fbshipit-source-id: c04b4f97396b837fe9265918fd9254a8ed362274
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants