babel plugin: refactor printer to use ast nodes not strings #306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💰 in the 🏦 ! |
YES |
josephsavona
force-pushed
the
printerstringrefactor
branch
from
a8018f8 to
1da330d
Compare
josephsavona
added a commit
that referenced
this pull request
Sep 18, 2015
Summary: `GraphQLPrinter` previously worked by concatenating strings, which makes composition and reusing functions much harder (see #297 for the workarounds that this required - bc a string may represent a literal value *or* some already printed code). This refactors the printer to use babel's builder functions, so that `print*` functions all return JavaScript AST nodes. Closes #306 Reviewed By: @yungsters Differential Revision: D2438530
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GraphQLPrinterpreviously worked by concatenating strings, which makes composition and reusing functions much harder (see #297 for the workarounds that this required - bc a string may represent a literal value or some already printed code). This refactors the printer to use babel's builder functions, so thatprint*functions all return JavaScript AST nodes.