Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indicate local state management is experimental in the documentation #3207

Closed
wants to merge 1 commit into from

Conversation

milieu
Copy link

@milieu milieu commented Oct 5, 2020

The "New in Relay Modern" post indicates this support is experimental. This changes the title of the documentation guide to match the announcement.

https://relay.dev/docs/en/new-in-relay-modern#client-schema-extensions-experimental

As of this writing this feature still seems to be experimental. I hope this changes soon, but for now "present me" is opening up this PR to make "past me" feel a little better about not realizing this was still experimental.

#2471 (open)
#2471 (comment) (comment from the original docs contributor, aw)
#1656 (closed, related)

I have completed the CLA

The "New in Relay Modern" post indicates this support is experimental. This changes the title of the guide to match the announcement.
https://relay.dev/docs/en/new-in-relay-modern#client-schema-extensions-experimental

As of this writing this feature still seems to be experimental.
facebook#2471 (open)
facebook#1656 (closed, related)
@sibelius
Copy link
Contributor

sibelius commented Oct 5, 2020

I'm don't think this is experimental, it just need more docs

@milieu
Copy link
Author

milieu commented Oct 18, 2020

@sibelius From #2471 (comment):

v9.1.0 has added this change which kills this workaround.

Because of the aforementioned change, you must downgrade the compiler back to v9.0.0 for the __typename fix to work.

The example provided in the Local State Management guide does not work anymore. A fundamental use case was broken by a minor version bump. That's why #2471 (comment) + the "What's new in Relay Modern" docs made me think this feature was still experimental.

@stale
Copy link

stale bot commented Dec 25, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Dec 25, 2020
@milieu
Copy link
Author

milieu commented Dec 27, 2020

Bump

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants