simplify tests with transformRelayClientPayload() #341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @wincent who had talked about doing something like this a while back. |
|
@facebook-github-bot import |
|
Thanks for importing. If you are an FB employee go to https://our.intern.facebook.com/intern/opensource/github/pull_request/140817766264897/int_phab to review. |
|
Excellent! Haven't actually looked at the code yet, but I love the idea of this. |
josephsavona
force-pushed
the
transform-client-payload
branch
4 times, most recently
from
f4e0aca to
1209ead
Compare
josephsavona
force-pushed
the
transform-client-payload
branch
from
1209ead to
1d5ea66
Compare
josephsavona
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A lot of our tests have to write data into the store before testing some other logic. However, the payloads must be manually constructed using
generateRQLFieldAlias(). It's not a big deal, but it's annoying.So this PR adds a new module
transformClientPayload(query: RelayQuery.Node, payload: Payload): Payload- it accepts payloads where the keys correspond to field names/aliases (which cannot be written into the store as-is), and returns an equivalent payload where keys are renamed to the serialization key of the corresponding field (which can be written to the store). See the unit test for this module for an example, and how it (slightly) simplifies tests that write to the store.I didn't convert all tests - I wanted to get feedback first.