Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a README to relay-config #3656

Closed
wants to merge 3 commits into from
Closed

Adds a README to relay-config #3656

wants to merge 3 commits into from

Conversation

orta
Copy link
Contributor

@orta orta commented Nov 28, 2021

I couldn't find any docs on how to use relay-config, or what config fields supported - so I figured I'd add them to the README as that was the first place I looked.

@maraisr
Copy link
Contributor

maraisr commented Nov 28, 2021

We should probably delete this package now? It has no more relevancy

@orta
Copy link
Contributor Author

orta commented Nov 29, 2021

It does? It works for me or was support upstreamed into the compiler

<edit> Confirmed that removing it breaks my setup with relay 12
<edit2> Ah, so with the upcoming relay 13, removing this makes sense.

IMO this package should get a README update and a deploy saying it's only for relay 12 and below then, because people will for sure get confused.

@facebook-github-bot
Copy link
Contributor

@alunyov has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants