Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to fix #3725 and #3739.
A new target
x86_64-unknown-linux-musl
has been added toci.yml
along with the additionalmusl-tools
package (can be removed in the future when this issue is resolved) and thehyper-tls/vendored
feature which allow to build openssl-sys package for the new target.I ended up with building directly on GitHub Action VM without custom docker image because it allows to implement it just as a new target in matrix. Building in docker image requires a separated job.
detect-libc is using for detecting correct platform.
Compiled binary has been tested inside
node:alpine
image. I'm not sure how to test it in the Bazel Sandbox, maybe it is better to ask the issue author.