Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add build for linux-musl target #3754

Closed
wants to merge 1 commit into from
Closed

Conversation

ch1ffa
Copy link
Contributor

@ch1ffa ch1ffa commented Jan 15, 2022

This PR attempts to fix #3725 and #3739.

A new target x86_64-unknown-linux-musl has been added to ci.yml along with the additional musl-tools package (can be removed in the future when this issue is resolved) and the hyper-tls/vendored feature which allow to build openssl-sys package for the new target.

I ended up with building directly on GitHub Action VM without custom docker image because it allows to implement it just as a new target in matrix. Building in docker image requires a separated job.

detect-libc is using for detecting correct platform.

Compiled binary has been tested inside node:alpine image. I'm not sure how to test it in the Bazel Sandbox, maybe it is better to ask the issue author.

@alunyov
Copy link
Contributor

alunyov commented Jan 17, 2022

Thank you @ch1ffa!

@facebook-github-bot
Copy link
Contributor

@alunyov has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@ch1ffa
Copy link
Contributor Author

ch1ffa commented Jan 17, 2022

@alunyov by the way, here is another example how to detect a proper target. They even use musl as a default target for x64.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

V13: relay-compiler not running in CI
3 participants