Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: disallow non-root node(id:...) fields #449

Closed

Conversation

josephsavona
Copy link
Contributor

Despite the Object Identification documentation, there has been some confusion in the community about whether the node field should be at the root or nested inside Viewer. This adds a validation check to the babel relay plugin to reject non-root node(id: ...) fields.

@wincent
Copy link
Contributor

wincent commented Oct 12, 2015

This is probably worth it, to avoid confusion.

I guess if I ever wanted to re-use node(id: $id) as field name deep down in the tree (probably a terrible idea) I'd have to come up with another name, or at least a different/additional argument, which seems fair.

@josephsavona
Copy link
Contributor Author

@facebook-github-bot import

@facebook-github-bot
Copy link
Contributor

Thanks for importing. If you are an FB employee go to https://our.intern.facebook.com/intern/opensource/github/pull_request/428362150700233/int_phab to review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants