Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attempt to avoid cycled when expanding updated ids to include impacted resolvers #4792

Closed
wants to merge 1 commit into from
Closed

Attempt to avoid cycled when expanding updated ids to include impacted resolvers #4792

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3,236 changes: 1,633 additions & 1,603 deletions packages/react-relay/__tests__/LiveResolvers-test.js
View file
Open in desktop

Large diffs are not rendered by default.

654 changes: 332 additions & 322 deletions packages/react-relay/__tests__/RelayResolverInterface-test.js
View file
Open in desktop

Large diffs are not rendered by default.

1,247 changes: 634 additions & 613 deletions packages/react-relay/__tests__/RelayResolverModel-test.js
View file
Open in desktop

Large diffs are not rendered by default.

688 changes: 347 additions & 341 deletions packages/react-relay/__tests__/RelayResolverNullableModelClientEdge-test.js
View file
Open in desktop

Large diffs are not rendered by default.

1,007 changes: 508 additions & 499 deletions packages/react-relay/__tests__/RelayResolvers-withOutputType-test.js
View file
Open in desktop

Large diffs are not rendered by default.

312 changes: 159 additions & 153 deletions packages/relay-runtime/store/__tests__/ClientEdgeToClientObject-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,62 +38,66 @@ afterEach(() => {
RelayFeatureFlags.ENABLE_RELAY_RESOLVERS = false;
});

test('Can read a deep portion of the schema that is backed by client edges to client objects.', () => {
const source = RelayRecordSource.create({
'client:root': {
__id: 'client:root',
__typename: '__Root',
me: {__ref: '1'},
},
'1': {
__id: '1',
id: '1',
__typename: 'User',
birthdate: {__ref: '2'},
},
'2': {
__id: '2',
id: '2',
__typename: 'Date',
day: 11,
month: 3,
},
});
const FooQuery = graphql`
query ClientEdgeToClientObjectTest1Query {
me {
astrological_sign {
__id
name
house
opposite {
__id
name
house
opposite {
describe.each([true, false])(
'AVOID_CYCLES_IN_RESOLVER_NOTIFICATION is %p',
avoidCycles => {
RelayFeatureFlags.AVOID_CYCLES_IN_RESOLVER_NOTIFICATION = avoidCycles;
test('Can read a deep portion of the schema that is backed by client edges to client objects.', () => {
const source = RelayRecordSource.create({
'client:root': {
__id: 'client:root',
__typename: '__Root',
me: {__ref: '1'},
},
'1': {
__id: '1',
id: '1',
__typename: 'User',
birthdate: {__ref: '2'},
},
'2': {
__id: '2',
id: '2',
__typename: 'Date',
day: 11,
month: 3,
},
});
const FooQuery = graphql`
query ClientEdgeToClientObjectTest1Query {
me {
astrological_sign {
__id
name
house
opposite {
__id
name
house
opposite {
__id
name
}
}
}
}
}
}
}
`;
`;

const operation = createOperationDescriptor(FooQuery, {});
const store = new LiveResolverStore(source, {
gcReleaseBufferSize: 0,
});
const operation = createOperationDescriptor(FooQuery, {});
const store = new LiveResolverStore(source, {
gcReleaseBufferSize: 0,
});

const environment = new RelayModernEnvironment({
network: RelayNetwork.create(jest.fn()),
store,
});
const environment = new RelayModernEnvironment({
network: RelayNetwork.create(jest.fn()),
store,
});

// $FlowFixMe[unclear-type] - lookup() doesn't have the nice types of reading a fragment through the actual APIs:
const {me}: any = environment.lookup(operation.fragment).data;
// $FlowFixMe[unclear-type] - lookup() doesn't have the nice types of reading a fragment through the actual APIs:
const {me}: any = environment.lookup(operation.fragment).data;

expect(me).toMatchInlineSnapshot(`
expect(me).toMatchInlineSnapshot(`
Object {
"astrological_sign": Object {
"__id": "client:AstrologicalSign:Pisces",
Expand All @@ -111,42 +115,42 @@ test('Can read a deep portion of the schema that is backed by client edges to cl
},
}
`);
});
});

test('Can read a plural client edge to list of client defined types', () => {
const source = RelayRecordSource.create({
'client:root': {
__id: 'client:root',
__typename: '__Root',
me: {__ref: '1'},
},
'1': {
__id: '1',
id: '1',
__typename: 'User',
},
});
const FooQuery = graphql`
query ClientEdgeToClientObjectTest2Query {
all_astrological_signs {
name
}
}
`;
test('Can read a plural client edge to list of client defined types', () => {
const source = RelayRecordSource.create({
'client:root': {
__id: 'client:root',
__typename: '__Root',
me: {__ref: '1'},
},
'1': {
__id: '1',
id: '1',
__typename: 'User',
},
});
const FooQuery = graphql`
query ClientEdgeToClientObjectTest2Query {
all_astrological_signs {
name
}
}
`;

const operation = createOperationDescriptor(FooQuery, {});
const store = new LiveResolverStore(source, {
gcReleaseBufferSize: 0,
});
const operation = createOperationDescriptor(FooQuery, {});
const store = new LiveResolverStore(source, {
gcReleaseBufferSize: 0,
});

const environment = new RelayModernEnvironment({
network: RelayNetwork.create(jest.fn()),
store,
});
const environment = new RelayModernEnvironment({
network: RelayNetwork.create(jest.fn()),
store,
});

const {data} = environment.lookup(operation.fragment);
const {data} = environment.lookup(operation.fragment);

expect(data).toMatchInlineSnapshot(`
expect(data).toMatchInlineSnapshot(`
Object {
"all_astrological_signs": Array [
Object {
Expand Down Expand Up @@ -188,88 +192,90 @@ test('Can read a plural client edge to list of client defined types', () => {
],
}
`);
});
});

test('Uses an existing client record if it already exists', () => {
const source = RelayRecordSource.create({
'client:root': {
__id: 'client:root',
__typename: '__Root',
me: {__ref: '1'},
},
'1': {
__id: '1',
id: '1',
__typename: 'User',
birthdate: {__ref: '2'},
},
'2': {
__id: '2',
id: '2',
__typename: 'Date',
day: 11,
month: 3,
},
});
test('Uses an existing client record if it already exists', () => {
const source = RelayRecordSource.create({
'client:root': {
__id: 'client:root',
__typename: '__Root',
me: {__ref: '1'},
},
'1': {
__id: '1',
id: '1',
__typename: 'User',
birthdate: {__ref: '2'},
},
'2': {
__id: '2',
id: '2',
__typename: 'Date',
day: 11,
month: 3,
},
});

const FooQuery = graphql`
query ClientEdgeToClientObjectTest3Query {
me {
astrological_sign {
__id
name
notes
const FooQuery = graphql`
query ClientEdgeToClientObjectTest3Query {
me {
astrological_sign {
__id
name
notes
}
}
}
}
}
`;
`;

const operation = createOperationDescriptor(FooQuery, {});
const liveStore = new LiveResolverStore(source, {
gcReleaseBufferSize: 0,
});
const operation = createOperationDescriptor(FooQuery, {});
const liveStore = new LiveResolverStore(source, {
gcReleaseBufferSize: 0,
});

const environment = new RelayModernEnvironment({
network: RelayNetwork.create(jest.fn()),
store: liveStore,
});
const environment = new RelayModernEnvironment({
network: RelayNetwork.create(jest.fn()),
store: liveStore,
});

const data: ClientEdgeToClientObjectTest3Query$data = (environment.lookup(
operation.fragment,
// $FlowFixMe[unclear-type] - lookup() doesn't have the nice types of reading a fragment through the actual APIs:
).data: any);
const data: ClientEdgeToClientObjectTest3Query$data = (environment.lookup(
operation.fragment,
// $FlowFixMe[unclear-type] - lookup() doesn't have the nice types of reading a fragment through the actual APIs:
).data: any);

expect(data).toEqual({
me: {
astrological_sign: {
__id: 'client:AstrologicalSign:Pisces',
name: 'Pisces',
notes: undefined,
},
},
});
expect(data).toEqual({
me: {
astrological_sign: {
__id: 'client:AstrologicalSign:Pisces',
name: 'Pisces',
notes: undefined,
},
},
});

commitLocalUpdate(environment, store => {
const id = data.me?.astrological_sign?.__id;
if (id == null) {
throw new Error('Expected to get an id');
}
const sign = store.get(id);
if (sign == null) {
throw new Error('Tried to reference a non-existent sign');
}
sign.setValue('This is a cool note.', 'notes');
});
commitLocalUpdate(environment, store => {
const id = data.me?.astrological_sign?.__id;
if (id == null) {
throw new Error('Expected to get an id');
}
const sign = store.get(id);
if (sign == null) {
throw new Error('Tried to reference a non-existent sign');
}
sign.setValue('This is a cool note.', 'notes');
});

const {data: newData} = environment.lookup(operation.fragment);
const {data: newData} = environment.lookup(operation.fragment);

expect(newData).toEqual({
me: {
astrological_sign: {
__id: 'client:AstrologicalSign:Pisces',
name: 'Pisces',
notes: 'This is a cool note.',
},
},
});
});
expect(newData).toEqual({
me: {
astrological_sign: {
__id: 'client:AstrologicalSign:Pisces',
name: 'Pisces',
notes: 'This is a cool note.',
},
},
});
});
},
);
Loading
Loading