Support route conditional fragments returning an array #915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (node && node.isIncluded()) { | ||
| nextChildren.push(node); | ||
| } | ||
| }); |
There was a problem hiding this comment.
I suspect that [].concat(...) will be slower than a manual check, especially since most cases will return a single value not an array. Let's explicitly check for array/scalar similar to what you did below.
xuorig
force-pushed
the
array-route-cond-fragments
branch
from
00d83a6 to
8c45667
Compare
|
Switched to manual check! |
xuorig
force-pushed
the
array-route-cond-fragments
branch
from
8c45667 to
a86d712
Compare
|
Sorry for leaving this one unattended for so long, @xuorig. Going to pull it in and see if it applies, tests pass etc. |
ghost
closed this
in
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gave #896 a try.
modifies
createNodeandgetChildrento possibly return an array of nodes when a route conditional fragment reference returns an array.Let me know what you think, It's seems weird to have
createNodepossibly return an Array but I'm not sure how it could be done without it!