Update HISTORY.md

HISTORY.md

@@ -9,6 +9,8 @@
 * Fixed a bug affecting `track_and_verify_wals_in_manifest`. Without the fix, application may see "open error: Corruption: Missing WAL with log number" while trying to open the db. The corruption is a false alarm but prevents DB open (#9766).
 * Fix segfault in FilePrefetchBuffer with async_io as it doesn't wait for pending jobs to complete on destruction.
 * Fix ERROR_HANDLER_AUTORESUME_RETRY_COUNT stat whose value was set wrong in portal.h
+* Fixed a bug for non-TransactionDB with avoid_flush_during_recovery = true and TransactionDB where in case of crash, min_log_number_to_keep may not change on recovery and persisting a new MANIFEST with advanced log_numbers for some column families, results in "column family inconsistency" error on second recovery. As a solution the corrupted WALs whose numbers are larger than the corrupted wal and smaller than the new WAL will be moved to archive folder.
+* Fixed a bug in RocksDB DB::Open() which may creates and writes to two new MANIFEST files even before recovery succeeds. Now writes to MANIFEST are persisted only after recovery is successful.
 
 ### New Features
 * For db_bench when --seed=0 or --seed is not set then it uses the current time as the seed value. Previously it used the value 1000.

db/db_impl/db_impl.h

@@ -1394,7 +1394,7 @@ class DBImpl : public DB {
   // recovered_seq is set to less than kMaxSequenceNumber if the log's tail is
   // skipped.
   // recovery_ctx stores the context about version edits and all those
-  // edits are persisted to new Manifest after succesfully syncing the new WAL.
+  // edits are persisted to new Manifest after successfully syncing the new WAL.
   virtual Status Recover(
       const std::vector<ColumnFamilyDescriptor>& column_families,
       bool read_only = false, bool error_if_wal_file_exists = false,
@@ -1420,7 +1420,7 @@ class DBImpl : public DB {
   // meantime, we find out the largest file number present in the paths, and
   // bump up the version set's next_file_number_ to be 1 + largest_file_number.
   // recovery_ctx stores the context about version edits and files to be
-  // deleted. All those edits are persisted to new Manifest after succesfully
+  // deleted. All those edits are persisted to new Manifest after successfully
   // syncing the new WAL.
   Status DeleteUnreferencedSstFiles(RecoveryContext* recovery_ctx);
 

db/db_impl/db_impl_open.cc

@@ -1355,7 +1355,8 @@ void DBImpl::MoveCorruptedWalFiles(std::vector<uint64_t>& wal_numbers,
 
   // Truncate the last WAL to reclaim the pre allocated space before
   // moving it.
-  GetLogSizeAndMaybeTruncate(wal_numbers.back(), /*truncate=*/true, nullptr);
+  GetLogSizeAndMaybeTruncate(wal_numbers.back(), /*truncate=*/true, nullptr)
+      .PermitUncheckedError();
 
   // Move all the WAL files from corrupted_wal_number + 1 to last WAL
   // (max_wal_number) to avoid column family inconsistency error to archival