Skip to content

Commit

Permalink
Fix bad include (#11797)
Browse files Browse the repository at this point in the history
Summary:
There was a `#include "port/lang.h"` situated inside an `extern "C" {` which just started causing the header to be unusuable in some contexts. This was a regression on the CircleCI job build-linux-unity-and-headers in #11792

The include, and another like it, now appears obsolete so removed.

Pull Request resolved: #11797

Test Plan: local `make check-headers` and `make`, CI

Reviewed By: jaykorean

Differential Revision: D48976826

Pulled By: pdillinger

fbshipit-source-id: 131d66969e045f2ded0f8936924ee30c9ef2655a
  • Loading branch information
pdillinger authored and facebook-github-bot committed Sep 5, 2023
1 parent 392d695 commit 6a98471
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 7 deletions.
3 changes: 0 additions & 3 deletions util/xxhash.h
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,6 @@
#ifndef XXH_NAMESPACE
#define XXH_NAMESPACE ROCKSDB_
#endif // !defined(XXH_NAMESPACE)

// for FALLTHROUGH_INTENDED, inserted as appropriate
#include "port/lang.h"
/* END RocksDB customizations */

// clang-format off
Expand Down
4 changes: 0 additions & 4 deletions util/xxph3.h
Original file line number Diff line number Diff line change
Expand Up @@ -386,10 +386,6 @@ typedef struct {
#define XXPH_STATIC_LINKING_ONLY
#endif

/* BEGIN RocksDB customizations */
#include "port/lang.h" /* for FALLTHROUGH_INTENDED, inserted as appropriate */
/* END RocksDB customizations */

/* *************************************
* Compiler Specific Options
***************************************/
Expand Down

0 comments on commit 6a98471

Please sign in to comment.