Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mac OS/X 32 bit build broken at commit 1a2cc27e013b561c9d3c8b81384d14443822057f #1110

Closed
warrenfalk opened this issue Apr 30, 2016 · 0 comments
Closed

Mac OS/X 32 bit build broken at commit 1a2cc27e013b561c9d3c8b81384d14443822057f #1110

warrenfalk opened this issue Apr 30, 2016 · 0 comments

Comments

@warrenfalk
Copy link
Contributor

Mac 32 bit build now fails with the following error:

db/column_family.cc:152:38: error: non-type template argument evaluates to 68719476736, which cannot be narrowed to type 'unsigned long' [-Wc++11-narrowing]
      std::integral_constant<size_t, 64ull << 30>>::type::value;
                                     ^
1 error generated.
warrenfalk added a commit to warrenfalk/rocksdb that referenced this issue Apr 30, 2016
@warrenfalk
Fix facebook#1110, 32-bit build failure on Mac OSX
12d969b 
Using explicit 64-bit type in conditional in platforms above 32-bits
This appears to be necessary on Mac OSX as std::conditional does not appear to short circuit and evaluates the third template arg
Making the third template arg be 64 bits explicitly works around this problem and will work on both 32 bit and 64+ bit platforms.
yiwu-arbug pushed a commit that referenced this issue May 2, 2016
@warrenfalk
Fix #1110, 32-bit build failure on Mac OSX (#1112)
cb08423 
Using explicit 64-bit type in conditional in platforms above 32-bits
This appears to be necessary on Mac OSX as std::conditional does not appear to short circuit and evaluates the third template arg
Making the third template arg be 64 bits explicitly works around this problem and will work on both 32 bit and 64+ bit platforms.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@warrenfalk