Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenBSD 7.2 error while building #11220

Closed
g2px1 opened this issue Feb 13, 2023 · 2 comments
Closed

OpenBSD 7.2 error while building #11220

g2px1 opened this issue Feb 13, 2023 · 2 comments
Labels
bug Confirmed RocksDB bugs

Comments

@g2px1
Copy link

g2px1 commented Feb 13, 2023

Expected behavior

builded RocksDB library

Actual behavior

port/stack_trace.cc:133:5: error: use of undeclared identifier 'PrintStackTraceLine'
    PrintStackTraceLine((symbols != nullptr) ? symbols[i] : nullptr, frames[i]);
    ^
port/stack_trace.cc:143:56: error: implicit conversion loses integer precision: 'unsigned long' to 'int' [-Werror,-Wshorten-64-to-32]
  PrintStack(&frames[first_frames_to_skip], num_frames - first_frames_to_skip);
  ~~~~~~~~~~                                ~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~
port/stack_trace.cc:156:23: error: implicit conversion loses integer precision: 'unsigned long' to 'int' [-Werror,-Wshorten-64-to-32]
  *num_frames = count - first_frames_to_skip;
              ~ ~~~~~~^~~~~~~~~~~~~~~~~~~~~~
3 errors generated.
gmake: *** [Makefile:2529: port/stack_trace.o] Error 1

Steps to reproduce the behavior

Try to build on OpenBSD through gmake

@g2px1 g2px1 changed the title OpenBSD error OpenBSD error while building Feb 13, 2023
@g2px1 g2px1 changed the title OpenBSD error while building OpenBSD 7.2 error while building Feb 13, 2023
@akankshamahajan15 akankshamahajan15 added bug Confirmed RocksDB bugs up-for-grabs Up for grabs labels May 19, 2023
@landryb
Copy link

landryb commented May 31, 2023

cf #11255 ?

@ajkr ajkr removed the up-for-grabs Up for grabs label Jun 1, 2023
@g2px1
Copy link
Author

g2px1 commented Jul 7, 2023

util/crc32c.cc:322:10: error: use of undeclared identifier 'crc32c_ppc'
  return crc32c_ppc(crc, (const unsigned char*)buf, size);
         ^
util/crc32c.cc:350:7: error: use of undeclared identifier 'arch_ppc_probe'
  if (arch_ppc_probe()) {
      ^
util/crc32c.cc:370:7: error: use of undeclared identifier 'arch_ppc_probe'
  if (arch_ppc_probe()) {
      ^
3 errors generated.
gmake: *** [Makefile:2515: util/crc32c.o] Error 1

facebook-github-bot pushed a commit that referenced this issue Aug 11, 2023
…m version 10.14 on macos (#11675)

Summary:
fixes #11220
fixes #11594

CXX is not initialized early enough in Makefile.
On OpenBSD its value is `g++` at first, and this results in several `command not found`, notably during the tests for HAVE_POWER8 and HAS_ALTIVEC which results in the build problem mentionned in #11594

reordering the Makefile fixes the issue, by placing the creation of make_config.mk and its import before any use of `$(CXX)`

Also, fixes the platofrm version for macos. it must be 10.14 now that rocksdb is using the C++17 standard

Pull Request resolved: #11675

Reviewed By: cbi42

Differential Revision: D48101615

Pulled By: ajkr

fbshipit-source-id: 1f1b4d4604480b31675140b92c6fe97dc55b8c75
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Confirmed RocksDB bugs
Projects
None yet
4 participants