Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always print hex for keys with corrupt results in stress tests #7531

Closed
ajkr opened this issue Oct 10, 2020 · 0 comments
Closed

Always print hex for keys with corrupt results in stress tests #7531

ajkr opened this issue Oct 10, 2020 · 0 comments
Assignees

Comments

@ajkr
Copy link
Contributor

ajkr commented Oct 10, 2020

Currently some failures look like this:

***Verification failed for column family 0 key 87500643: Value not found: NotFound:***

However this is difficult to debug since the translation from integer used to generate the key into the actual key bytes is complex and configuration-dependent. That makes it difficult to do manual investigation like looking for the key in the SST files. It'd be good to accompany the key integer with the actual key bytes (in hex format) in all error messages printed by the stress tests.

@jay-zhuang jay-zhuang self-assigned this Oct 10, 2020
@jay-zhuang jay-zhuang removed the up-for-grabs Up for grabs label Oct 10, 2020
facebook-github-bot pushed a commit that referenced this issue Oct 13, 2020
Summary:
db_stress prints key in both id and hex. #7531

Pull Request resolved: #7533

Test Plan: local test

Reviewed By: akankshamahajan15

Differential Revision: D24252725

Pulled By: jay-zhuang

fbshipit-source-id: f0c1409a0568874df36949d5da139316d978fa98
codingrhythm pushed a commit to SafetyCulture/rocksdb that referenced this issue Mar 5, 2021
Summary:
db_stress prints key in both id and hex. facebook#7531

Pull Request resolved: facebook#7533

Test Plan: local test

Reviewed By: akankshamahajan15

Differential Revision: D24252725

Pulled By: jay-zhuang

fbshipit-source-id: f0c1409a0568874df36949d5da139316d978fa98
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants