Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't build v7.0.2 ROCKSDB_LITE on macOS 12.3/aarm64 #9701

Closed
meangrape opened this issue Mar 15, 2022 · 0 comments
Closed

Can't build v7.0.2 ROCKSDB_LITE on macOS 12.3/aarm64 #9701

meangrape opened this issue Mar 15, 2022 · 0 comments
Assignees
@hx235
Labels
Build build, makefile, cmake, scripts up-for-grabs Up for grabs

Comments

@meangrape
Copy link

meangrape commented Mar 15, 2022 •
edited
Loading

I'm unable to build ROCKSDB_LITE using LITE=1 make static_lib. To verify I'm doing things correctly I modified the Makefile to emit the pertinent variable settings. Note: make static_lib works fine.

$DEBUG_LEVEL is 0
$LITE is [1]
$OPT is [-DROCKSDB_LITE]
$OPTIMIZE_LEVEL is [-Os]

Expected behavior

I get a library!

Actual behavior

  CC       file/sequence_file_reader.o
  CC       file/sst_file_manager_impl.o
  CC       file/writable_file_writer.o
In file included from file/writable_file_writer.cc:10:
./file/writable_file_writer.h:163:15: error: private field 'temperature_' is not used [-Werror,-Wunused-private-field]
  Temperature temperature_;
              ^
1 error generated.
make: *** [file/writable_file_writer.o] Error 1

Steps to reproduce the behavior

LITE=1 make static_lib works every time.
@ajkr ajkr added up-for-grabs Up for grabs Build build, makefile, cmake, scripts labels Mar 15, 2022
@hx235 hx235 mentioned this issue Apr 17, 2022
Closed
facebook-github-bot pushed a commit that referenced this issue Apr 18, 2022
@hx235 @facebook-github-bot
Conditionally declare and define variable that is unused in LITE mode (…
e83c554 
…#9854)

Summary:
Context:
As mentioned in #9701, we have the following in LITE=1 make static_lib for v7.0.2
```
  CC       file/sequence_file_reader.o
  CC       file/sst_file_manager_impl.o
  CC       file/writable_file_writer.o
In file included from file/writable_file_writer.cc:10:
./file/writable_file_writer.h:163:15: error: private field 'temperature_' is not used [-Werror,-Wunused-private-field]
  Temperature temperature_;
              ^
1 error generated.
make: *** [file/writable_file_writer.o] Error 1
```

 as titled

Pull Request resolved: #9854

Test Plan:
- Local `LITE=1 make static_lib` reveals the same error and error is gone after this fix
- CI

Reviewed By: ajkr, jay-zhuang

Differential Revision: D35706585

Pulled By: hx235

fbshipit-source-id: 7743310298231ad6866304ffa2225c8abdc91d9a
@hx235 hx235 self-assigned this Apr 18, 2022
hx235 added a commit to hx235/rocksdb that referenced this issue Apr 19, 2022
@hx235
Conditionally declare and define variable that is unused in LITE mode (…
3d15d07 
…facebook#9854)

Summary:
Context:
As mentioned in facebook#9701, we have the following in LITE=1 make static_lib for v7.0.2
```
  CC       file/sequence_file_reader.o
  CC       file/sst_file_manager_impl.o
  CC       file/writable_file_writer.o
In file included from file/writable_file_writer.cc:10:
./file/writable_file_writer.h:163:15: error: private field 'temperature_' is not used [-Werror,-Wunused-private-field]
  Temperature temperature_;
              ^
1 error generated.
make: *** [file/writable_file_writer.o] Error 1
```

 as titled

Pull Request resolved: facebook#9854

Test Plan:
- Local `LITE=1 make static_lib` reveals the same error and error is gone after this fix
- CI

Reviewed By: ajkr, jay-zhuang

Differential Revision: D35706585

Pulled By: hx235

fbshipit-source-id: 7743310298231ad6866304ffa2225c8abdc91d9a
hx235 added a commit to hx235/rocksdb that referenced this issue Apr 19, 2022
@hx235
Conditionally declare and define variable that is unused in LITE mode (…
e421833 
…facebook#9854)

Summary:
Context:
As mentioned in facebook#9701, we have the following in LITE=1 make static_lib for v7.0.2
```
  CC       file/sequence_file_reader.o
  CC       file/sst_file_manager_impl.o
  CC       file/writable_file_writer.o
In file included from file/writable_file_writer.cc:10:
./file/writable_file_writer.h:163:15: error: private field 'temperature_' is not used [-Werror,-Wunused-private-field]
  Temperature temperature_;
              ^
1 error generated.
make: *** [file/writable_file_writer.o] Error 1
```

 as titled

Pull Request resolved: facebook#9854

Test Plan:
- Local `LITE=1 make static_lib` reveals the same error and error is gone after this fix
- CI

Reviewed By: ajkr, jay-zhuang

Differential Revision: D35706585

Pulled By: hx235

fbshipit-source-id: 7743310298231ad6866304ffa2225c8abdc91d9a
hx235 added a commit to hx235/rocksdb that referenced this issue Apr 19, 2022
@hx235
Conditionally declare and define variable that is unused in LITE mode (…
4f4c616 
…facebook#9854)

Summary:
Context:
As mentioned in facebook#9701, we have the following in LITE=1 make static_lib for v7.0.2
```
  CC       file/sequence_file_reader.o
  CC       file/sst_file_manager_impl.o
  CC       file/writable_file_writer.o
In file included from file/writable_file_writer.cc:10:
./file/writable_file_writer.h:163:15: error: private field 'temperature_' is not used [-Werror,-Wunused-private-field]
  Temperature temperature_;
              ^
1 error generated.
make: *** [file/writable_file_writer.o] Error 1
```

 as titled

Pull Request resolved: facebook#9854

Test Plan:
- Local `LITE=1 make static_lib` reveals the same error and error is gone after this fix
- CI

Reviewed By: ajkr, jay-zhuang

Differential Revision: D35706585

Pulled By: hx235

fbshipit-source-id: 7743310298231ad6866304ffa2225c8abdc91d9a
jay-zhuang pushed a commit that referenced this issue Apr 19, 2022
@hx235 @jay-zhuang
Conditionally declare and define variable that is unused in LITE mode (…
b3c68d8 
…#9854)

Summary:
Context:
As mentioned in #9701, we have the following in LITE=1 make static_lib for v7.0.2
```
  CC       file/sequence_file_reader.o
  CC       file/sst_file_manager_impl.o
  CC       file/writable_file_writer.o
In file included from file/writable_file_writer.cc:10:
./file/writable_file_writer.h:163:15: error: private field 'temperature_' is not used [-Werror,-Wunused-private-field]
  Temperature temperature_;
              ^
1 error generated.
make: *** [file/writable_file_writer.o] Error 1
```

 as titled

Pull Request resolved: #9854

Test Plan:
- Local `LITE=1 make static_lib` reveals the same error and error is gone after this fix
- CI

Reviewed By: ajkr, jay-zhuang

Differential Revision: D35706585

Pulled By: hx235

fbshipit-source-id: 7743310298231ad6866304ffa2225c8abdc91d9a
hx235 added a commit to hx235/rocksdb that referenced this issue Apr 19, 2022
@hx235
Conditionally declare and define variable that is unused in LITE mode (…
985c874 
…facebook#9854)

Summary:
Context:
As mentioned in facebook#9701, we have the following in LITE=1 make static_lib for v7.0.2
```
  CC       file/sequence_file_reader.o
  CC       file/sst_file_manager_impl.o
  CC       file/writable_file_writer.o
In file included from file/writable_file_writer.cc:10:
./file/writable_file_writer.h:163:15: error: private field 'temperature_' is not used [-Werror,-Wunused-private-field]
  Temperature temperature_;
              ^
1 error generated.
make: *** [file/writable_file_writer.o] Error 1
```

 as titled

Pull Request resolved: facebook#9854

Test Plan:
- Local `LITE=1 make static_lib` reveals the same error and error is gone after this fix
- CI

Reviewed By: ajkr, jay-zhuang

Differential Revision: D35706585

Pulled By: hx235

fbshipit-source-id: 7743310298231ad6866304ffa2225c8abdc91d9a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hx235 hx235

Labels
Build build, makefile, cmake, scripts up-for-grabs Up for grabs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@meangrape @ajkr @hx235