Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Cache as a Customizable Object #10084

Open
wants to merge 44 commits into
base: main
Choose a base branch
from
Open
Changes from 1 commit
Commits
Show all changes
44 commits
Select commit Hold shift + click to select a range
15eb003
First pass at making Cache into Customizable
mrambacher Jul 30, 2021
cf8cd5a
Fix ClockCache for Customizable; fix LITE mode
mrambacher Jul 30, 2021
93faa3a
Merge branch 'master' into CustomCache
mrambacher Aug 2, 2021
229ab4a
Revert MemoryAllocator changes
mrambacher Aug 9, 2021
ce46b19
Merge branch 'master' into CustomCache
mrambacher Aug 9, 2021
405f0bc
Fix LITE mode
mrambacher Aug 9, 2021
0d71eb2
Update to latest
mrambacher Sep 15, 2021
a7148d6
Merge branch 'main' into CustomCache
mrambacher Oct 4, 2021
c876533
Make Cache into a Customizable, Managed Object
mrambacher Oct 8, 2021
601ae25
Fix build/test issues
mrambacher Oct 8, 2021
247f32d
make format
mrambacher Oct 8, 2021
5652289
Another format...
mrambacher Oct 8, 2021
0cc22db
Update to latest
mrambacher Nov 8, 2021
cf14565
Remove backup files
mrambacher Nov 8, 2021
35cac19
Address PR Comments
mrambacher Nov 9, 2021
b656948
Fix Linux build issue
mrambacher Nov 9, 2021
52cc40a
make format
mrambacher Nov 9, 2021
dfc4013
Add more using statements for Linux
mrambacher Nov 9, 2021
bc3941d
Attempt to fix build issue
mrambacher Nov 9, 2021
cad0cf9
Fix unity test failure
mrambacher Nov 12, 2021
d3cbd92
Merge branch 'main' into CustomCache
mrambacher Nov 23, 2021
a22f56f
Merge branch 'main' into CustomCache
mrambacher May 26, 2022
2b006be
Fix merge
mrambacher May 26, 2022
6c6815a
Add FastLRUCache to the ObjectRegistry
mrambacher May 27, 2022
b59e773
Fix Cache::CreateFromString and comparisons
mrambacher May 31, 2022
d58a7d0
Merge branch 'main' into CreateCacheFromString
mrambacher Jun 3, 2022
ed07649
Update to main; Address PR comments
mrambacher Jun 3, 2022
887a5c6
Another make format
mrambacher Jun 3, 2022
ada584c
Rename capacity to options mutex
mrambacher Jun 14, 2022
f06893b
Merge branch 'main' into CreateCacheFromString
mrambacher Jun 15, 2022
bd1945f
Fix merge; add Cache::CreateFromString to db_stress
mrambacher Jun 15, 2022
c3d6bd7
make format
mrambacher Jun 15, 2022
14509a0
Merge remote-tracking branch 'origin/main' into pr/10084
pdillinger Jun 16, 2022
799e47a
Hopefully fix analyzer error
pdillinger Jun 16, 2022
cf11b94
Don't change to `const std::shared_ptr<X>&` if always saving a copy
pdillinger Jun 16, 2022
ddbae7d
Merge branch 'main' into CreateCacheFromString
mrambacher Jul 13, 2022
6e5f5c9
Update to latest
mrambacher Jul 15, 2022
e91119a
Yet another make format
mrambacher Jul 15, 2022
db1ab36
Merge branch 'main' into CreateCacheFromString
mrambacher Jul 26, 2022
5a2e8b8
Fix test
mrambacher Jul 26, 2022
4502655
Merge branch 'main' into CreateCacheFromString
mrambacher Jul 28, 2022
4ad004d
Fix merge
mrambacher Jul 28, 2022
23e6d33
Merge branch 'main' into CreateCacheFromString
mrambacher Sep 15, 2022
760821c
Update lru_cache.cc
mrambacher Sep 16, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix LITE mode
  • Loading branch information
mrambacher committed Aug 9, 2021
commit 405f0bcfbaa9506bba7230ed5428339645dea1a3
2 changes: 2 additions & 0 deletions options/options_test.cc
Original file line number Diff line number Diff line change
@@ -835,6 +835,7 @@ TEST_F(OptionsTest, OldInterfaceTest) {
#endif // !ROCKSDB_LITE

namespace {
#ifndef ROCKSDB_LITE
static void CheckCacheSettings(const std::shared_ptr<Cache>& cache,
size_t capacity, int shard_bits, bool strict,
double ratio) {
@@ -848,6 +849,7 @@ static void CheckCacheSettings(const std::shared_ptr<Cache>& cache,
ASSERT_NE(lru, nullptr);
ASSERT_EQ(lru->GetHighPriPoolRatio(), ratio);
}
#endif // !ROCKSDB_LITE
} // namespace

#ifndef ROCKSDB_LITE // GetBlockBasedTableOptionsFromString is not supported