Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calculate table size of FastLRUCache more accurately #10235

Closed
wants to merge 13 commits into from
Closed

Calculate table size of FastLRUCache more accurately #10235

wants to merge 13 commits into from

Conversation

guidotag
Copy link
Contributor

@guidotag guidotag commented Jun 22, 2022 •
edited
Loading

Summary: Calculate the required size of the hash table in FastLRUCache more accurately.

Test plan: make -j24 check

@guidotag guidotag requested a review from pdillinger June 22, 2022 22:42
@guidotag guidotag changed the title Bake load factor in CalcHashBits calculation Calculate table size of FastLRUCache more accurately Jun 23, 2022
@guidotag guidotag requested a review from gitbw95 June 23, 2022 23:17
@facebook-github-bot
Copy link
Contributor

@guidotag has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

1 similar comment
@facebook-github-bot
Copy link
Contributor

@guidotag has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@guidotag has updated the pull request. You must reimport the pull request before landing.

@facebook-github-bot
Copy link
Contributor

@guidotag has updated the pull request. You must reimport the pull request before landing.

gitbw95
gitbw95 reviewed Jun 27, 2022
View reviewed changes
cache/lru_cache_test.cc Outdated Show resolved Hide resolved
@facebook-github-bot
Copy link
Contributor

@guidotag has updated the pull request. You must reimport the pull request before landing.

@facebook-github-bot
Copy link
Contributor

@guidotag has updated the pull request. You must reimport the pull request before landing.

@facebook-github-bot
Copy link
Contributor

@guidotag has updated the pull request. You must reimport the pull request before landing.

@facebook-github-bot
Copy link
Contributor

@guidotag has updated the pull request. You must reimport the pull request before landing.

@facebook-github-bot
Copy link
Contributor

@guidotag has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

gitbw95
gitbw95 reviewed Jun 27, 2022
View reviewed changes
cache/fast_lru_cache.h Outdated Show resolved Hide resolved
@facebook-github-bot
Copy link
Contributor

@guidotag has updated the pull request. You must reimport the pull request before landing.

@facebook-github-bot
Copy link
Contributor

@guidotag has updated the pull request. You must reimport the pull request before landing.

1 similar comment
@facebook-github-bot
Copy link
Contributor

@guidotag has updated the pull request. You must reimport the pull request before landing.

@facebook-github-bot
Copy link
Contributor

@guidotag has updated the pull request. You must reimport the pull request before landing.

@facebook-github-bot
Copy link
Contributor

@guidotag has updated the pull request. You must reimport the pull request before landing.

gitbw95
gitbw95 approved these changes Jun 28, 2022
View reviewed changes
Copy link
Contributor

@gitbw95 gitbw95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@facebook-github-bot
Copy link
Contributor

@guidotag has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@guidotag guidotag deleted the main branch July 1, 2022 03:08
@guidotag guidotag restored the main branch July 1, 2022 03:08
@guidotag guidotag deleted the main branch July 1, 2022 03:09
@guidotag guidotag restored the main branch July 1, 2022 03:11
@guidotag guidotag mentioned this pull request Jul 4, 2022
Open
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gitbw95 gitbw95 gitbw95 approved these changes

@pdillinger pdillinger Awaiting requested review from pdillinger

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@guidotag @facebook-github-bot @gitbw95