Expand Statistics support in the C API #11263
Conversation
amatveev-cf
changed the title
|
waiting_skeleton.jpg |
db/c_test.c
Outdated
| CheckNoError(err); | ||
|
|
||
| rocksdb_options_enable_statistics(options); | ||
| rocksdb_options_set_statistics_level(options, 5); |
There was a problem hiding this comment.
Similar suggestion here: use static_cast<uint8_t>(StatsLevel::kAll), assuming by "5", you want to mean StatsLevel::kAll
There was a problem hiding this comment.
Please see my #11263 (comment)
| CheckCondition(0 != rocksdb_options_statistics_get_ticker_count( | ||
| options, BYTES_WRITTEN_TICKER)); | ||
| rocksdb_options_statistics_get_histogram_data(options, DB_WRITE_HIST, hist); | ||
| CheckCondition(0 != rocksdb_statistics_histogram_data_get_sum(hist)); |
There was a problem hiding this comment.
Can we also check for other fields rocksdb_statistics_histogram_data_get_*(hist) to be non-zero?
|
@hx235 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Added functions for changing statistics level and collecting tickers and histograms programmatically via the C API
amatveev-cf
force-pushed
the
c_api_statistics
branch
from
8549da0
to
d68bc6f
Compare
|
@amatveev-cf has updated the pull request. You must reimport the pull request before landing. |
|
@amatveev-cf has updated the pull request. You must reimport the pull request before landing. |
|
@hx235 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@amatveev-cf has updated the pull request. You must reimport the pull request before landing. |
|
@amatveev-cf has updated the pull request. You must reimport the pull request before landing. |
|
@hx235 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Adds a few missing features to the C API:
Test Plan: unit tests