Add deltaiterator upperbound check #11662
Conversation
|
Seems to fix the issue described in #2343 ( |
|
@ajkr has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
1 similar comment
|
@ajkr has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@cz2h has updated the pull request. You must reimport the pull request before landing. |
|
@ajkr @jsteemann Many thanks for the quick review. Kindly format the code to pass the last styling test. |
|
@ajkr has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
| @@ -307,7 +312,8 @@ void BaseDeltaIterator::UpdateCurrent() { | |||
| if (comparator_->CompareWithoutTimestamp( | |||
| delta_entry.key, /*a_has_ts=*/false, *iterate_upper_bound_, | |||
| /*b_has_ts=*/false) >= 0) { | |||
| // out of upper bound -> finished. | |||
| // out of upper bound -> delta finished. | |||
| delta_iterator_out_of_bound_ = true; | |||
There was a problem hiding this comment.
Should we reset delta_iterator_out_of_bound_ to false when a user calls Seek* again?
There was a problem hiding this comment.
Good point... we should probably pass the upper_bound down to the WBWIIteratorImpl and have it do the upper-bound check normally, i.e., by returning Valid() == false upon reaching the upper-bound.
|
Another usage of |
|
@cz2h has updated the pull request. You must reimport the pull request before landing. |
Fixes issue 11606.
Fixes #2343.
Fix problem of WBWIIteratorImpl not disabling itself when it's delta iterator is at entry out of upperbound.