Avoid an std::map copy in persistent stats #11681
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ajkr has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
rockeet
pushed a commit
to topling/toplingdb
that referenced
this pull request
Dec 18, 2023
Summary: An internal user reported this copy showing up in a CPU profile. We can use move instead. Pull Request resolved: facebook/rocksdb#11681 Differential Revision: D48103170 Pulled By: ajkr fbshipit-source-id: 083d6470181a0041bb5275b657aa61bee23a3729
rockeet
pushed a commit
to topling/toplingdb
that referenced
this pull request
Dec 22, 2023
Summary: An internal user reported this copy showing up in a CPU profile. We can use move instead. Pull Request resolved: facebook/rocksdb#11681 Differential Revision: D48103170 Pulled By: ajkr fbshipit-source-id: 083d6470181a0041bb5275b657aa61bee23a3729
rockeet
pushed a commit
to topling/toplingdb
that referenced
this pull request
Sep 1, 2024
Summary: An internal user reported this copy showing up in a CPU profile. We can use move instead. Pull Request resolved: facebook/rocksdb#11681 Differential Revision: D48103170 Pulled By: ajkr fbshipit-source-id: 083d6470181a0041bb5275b657aa61bee23a3729
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An internal user reported this copy showing up in a CPU profile. We can use move instead.