Add unit test for default temperature #11722
Conversation
jowlyzhang
force-pushed
the
ut_default_temp
branch
2 times, most recently
from
31c5590
to
eab8fce
Compare
|
@jowlyzhang has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
jowlyzhang
force-pushed
the
ut_default_temp
branch
from
eab8fce
to
90d1056
Compare
|
@jowlyzhang has updated the pull request. You must reimport the pull request before landing. |
jowlyzhang
changed the title
|
Looks like re-import is needed |
Luckily, looks like Anand hasn't cut 8.6 yet, I will reach out to him for a favor to wait on this one. Thanks for the quick review! |
|
@jowlyzhang has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
jowlyzhang
force-pushed
the
ut_default_temp
branch
from
90d1056
to
d643c90
Compare
|
@jowlyzhang has updated the pull request. You must reimport the pull request before landing. |
|
@jowlyzhang has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Sorry that this is mis info, I will patch this. |
|
@jowlyzhang merged this pull request in 03a7441. |
Summary: This piggy back the existing last level file temperature statistics test to test the default temperature becoming effective. While adding this unit test, I found that the approach to swap out and use default temperature in `VersionBuilder::LoadTableHandlers` will miss the L0 files created from flush, and only work for existing SST files, SST files created by compaction. So this PR moves that logic to `TableCache::GetTableReader`. Pull Request resolved: #11722 Test Plan: ``` ./db_test2 --gtest_filter="*LastLevelStatistics*" make all check ``` Reviewed By: pdillinger Differential Revision: D48489171 Pulled By: jowlyzhang fbshipit-source-id: ac29f7d484916f3218729594c5bb35c4f2979ac2
This piggy back the existing last level file temperature statistics test to test the default temperature becoming effective.
While adding this unit test, I found that the approach to swap out and use default temperature in
VersionBuilder::LoadTableHandlerswill miss the L0 files created from flush, and only work for existing SST files, SST files created by compaction. So this PR moves that logic toTableCache::GetTableReader.Test Plan: