Fix a bug of rocksdb.file.read.verify.file.checksums.micros not being populated #11836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hx235
changed the title
|
@hx235 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
ajkr
approved these changes
Sep 14, 2023
| @@ -226,7 +226,8 @@ Status ExternalSstFileIngestionJob::Prepare( | |||
| &generated_checksum_func_name, | |||
| ingestion_options_.verify_checksums_readahead_size, | |||
| db_options_.allow_mmap_reads, io_tracer_, | |||
| db_options_.rate_limiter.get(), ro); | |||
| db_options_.rate_limiter.get(), ro, nullptr /* stats */, | |||
There was a problem hiding this comment.
db_options_.stats, otherwise we'll have the same problem next time
There was a problem hiding this comment.
I don't think we have external sst ingestion read stats yet but will do this fix in advance!
| @@ -1067,7 +1068,7 @@ IOStatus ExternalSstFileIngestionJob::GenerateChecksumForIngestedFile( | |||
| &file_checksum, &file_checksum_func_name, | |||
| ingestion_options_.verify_checksums_readahead_size, | |||
| db_options_.allow_mmap_reads, io_tracer_, db_options_.rate_limiter.get(), | |||
| ro); | |||
| ro, nullptr /* stats */, nullptr /* clock */); | |||
There was a problem hiding this comment.
I don't think we have external sst ingestion read stats yet but will do this fix in advance!
|
@hx235 has updated the pull request. You must reimport the pull request before landing. |
|
@hx235 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
hx235
added a commit
that referenced
this pull request
Sep 15, 2023
… populated (#11836) Summary: **Context/Summary:** `rocksdb.file.read.verify.file.checksums.micros ` was added in #11444 but the related path was not populated with statistics and clock object correctly so the actual statistics collection didn't happen. This PR fixed it. Pull Request resolved: #11836 Test Plan: Setup: ``` ./db_bench --benchmarks="fillrandom" --file_checksum=1 --num=100 --db=/dev/shm/rocksdb ``` Run: ``` ./db_bench --use_existing_db=1 --benchmarks="verifyfilechecksums" --file_checksum=1 --num=100 --db=/dev/shm/rocksdb --statistics=1 --stats_level=4 ``` Post-PR ``` rocksdb.file.read.verify.file.checksums.micros P50 : 9.000000 P95 : 9.000000 P99 : 9.000000 P100 : 9.000000 COUNT : 1 SUM : 9 ``` Pre-PR ``` rocksdb.file.read.verify.file.checksums.micros P50 : 0.000000 P95 : 0.000000 P99 : 0.000000 P100 : 0.000000 COUNT : 0 SUM : 0 ``` Reviewed By: ajkr Differential Revision: D49293378 Pulled By: hx235 fbshipit-source-id: 1acd8b828c28e088d0c5d63897f53cd180b82f42
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context/Summary:
rocksdb.file.read.verify.file.checksums.microswas added in #11444 but the related path was not populated with statistics and clock object correctly so the actual statistics collection didn't happen. This PR fixed it.Test:
Setup:
Run:
Post-PR
Pre-PR