Java FFI blog post - Post-publication issues with images #12366
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review comments Broken image links
alanpaxton
changed the title
ajkr
approved these changes
Feb 21, 2024
|
@ajkr has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
Hi @ajkr @adamretter my updated blog post has fixed one of the images, but (for reasons I can't understand) the link to "https://rocksdb.org/static/images/jni-ffi/jmh-result-pinnable-vs-output-plot.pdf" isn't working in the main blog post (https://rocksdb.org/blog/#copies-versus-calls). I can right click the alt in Chrome and "open image in new tab" so everything seems to have built and the PDF exists. Is there any issue with (some kinds of) PDF file ? I'd be grateful for any suggestion.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Review comments
Broken image links